CMake: allow private libraries to be used on older OSes #83602
Merged
+37
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since swiftlang#64187 we are not importing automatically StringProcessing when building the stdlib -- this is especially important for StdlibUnittest, since it needs to run on older OSes. Addresses rdar://157622116
To do so, use the deployment target versions used for tests. Addresses rdar://157622116
edymtt
requested review from
etcwilde,
shahmishal,
Azoy and
justice-adams-apple
|
@swift-ci please test |
|
I do not have access to rdar, so I'm out of context. But I'd suppose that autodiff test changes are ok. |
|
@swift-ci please build toolchain |
|
Windows toolchain failure looks unrelated, since it is happening in SourceKit-LSP tests |
|
@swift-ci please build toolchain Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way they can be used in backdeployment tests.
To do so, use the deployment target versions for tests (not the one for the compiler/stdlib), and remove an unneeded dependency on StringProcessing.
Piggyback a change to disable an Autodiff test on backdeployment configurations
Addresses rdar://157622116